make corrections #122
make corrections #122
Conversation
There was a problem hiding this comment.
PR Overview
This PR corrects the handling of input types and parameter types to align with mupdf expectations for document opening and page rendering.
- Updated Document::open to accept any type implementing AsRef with appropriate OS-specific conversions.
- Changed Page::to_pixmap to accept a bool for the alpha parameter instead of a f32.
- Adjusted the test in tests/test_issues.rs to pass a boolean value for the alpha parameter.
Reviewed Changes
| File | Description |
|---|---|
| src/document.rs | Updated the open method for generic path handling. |
| src/page.rs | Changed the alpha parameter from f32 to bool in to_pixmap. |
| tests/test_issues.rs | Modified the test to pass a boolean for alpha. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
|
|
||
| #[cfg(not(windows))] | ||
| let raw = p.as_ref().as_os_str().as_encoded_bytes(); | ||
| let c_name = CString::new(raw)?; |
There was a problem hiding this comment.
I'm not quite sure about this code. I understand the idea, however we are setting the users up with the expectation that every path is accepted here, which then is not the case on windows.
Maybe creating a newtype that is From<&str> for X and AsRef<X> for &str while creatable from a Path if the path is utf-8 on windows. This would allow us to skip with check entirely if a &str is used, as we already know it's utf-8. It would also make it a bit clearer that this is a failure that could occur. I'm only throwing ideas out so maybe that's a bit overkill. Else this looks good.
open(2)per 12.2 https://ghostscript.com/~robin/mupdf_explored.pdf#page=83